Discussion:
[review'n'merge] grammar correction for whisperback
Add Reply
emma peel
2018-04-27 11:56:00 UTC
Reply
Permalink
Raw Message
ey there:

please review this patch with a grammar correction for WhisperBack.

thanks to kingu at trasifex that spotted it.
intrigeri
2018-04-29 08:04:56 UTC
Reply
Permalink
Raw Message
Post by emma peel
please review this patch with a grammar correction for WhisperBack.
Thanks, this looks good to me. I'll apply this once bertagaz has
pushed to whisperback.git the changes he made during the 3.6 release
(#15440).
intrigeri
2018-05-21 16:00:07 UTC
Reply
Permalink
Raw Message
Post by intrigeri
Post by emma peel
please review this patch with a grammar correction for WhisperBack.
Thanks, this looks good to me. I'll apply this once bertagaz has
pushed […]
I've now applied this patch even though it's debatable whether this is
a grammar correction:

https://en.wikipedia.org/wiki/Serial_comma

(I've not found any guidance about it in our doc style guide.)

Cheers,
--
intrigeri
emma peel
2018-05-22 07:00:00 UTC
Reply
Permalink
Raw Message
Post by intrigeri
Post by intrigeri
Post by emma peel
please review this patch with a grammar correction for WhisperBack.
Thanks, this looks good to me. I'll apply this once bertagaz has
pushed [
]
I've now applied this patch even though it's debatable whether this is
https://en.wikipedia.org/wiki/Serial_comma
Any native speakers around? I want to add the 'or' but I have no preferences regarding the comma...
Austin English
2018-05-22 07:05:30 UTC
Reply
Permalink
Raw Message
Post by emma peel
Post by intrigeri
Post by intrigeri
Post by emma peel
please review this patch with a grammar correction for WhisperBack.
Thanks, this looks good to me. I'll apply this once bertagaz has
pushed [
]
I've now applied this patch even though it's debatable whether this is
https://en.wikipedia.org/wiki/Serial_comma
Any native speakers around? I want to add the 'or' but I have no
preferences regarding the comma...
_______________________________________________
Tails-dev mailing list
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to
Native (American) speaker. I typically use the Oxford comma. To me this
change is fine, though I can't speak for British English.
sajolida
2018-05-22 09:24:00 UTC
Reply
Permalink
Raw Message
Post by intrigeri
Post by intrigeri
Post by emma peel
please review this patch with a grammar correction for WhisperBack.
Thanks, this looks good to me. I'll apply this once bertagaz has
pushed […]
I've now applied this patch even though it's debatable whether this is
https://en.wikipedia.org/wiki/Serial_comma
(I've not found any guidance about it in our doc style guide.)
I've used serial commas consistently for years. See the many commits
referring to 'serial comma'.

I now added it to our style guide with 3037353da0 :)

In some cases a serial comma can change the meaning of a sentence so I
think it's grammar.
--
sajolida
Loading...